[rocprof-compute] Adding Triton backend to marker injection by ggottipa-amd · Pull Request #6901 · ROCm/rocm-systems

ggottipa-amd · 2026-06-08T09:28:48Z

Motivation

This PR enables operator tracing for Triton workloads.

Technical Details

Wraps Triton's launch entry points — JITFunction.run for eager kernels and CompiledKernel.run/call for compiled/Inductor kernels — to emit a ROCTX marker per launch, attributed to the user's call site.
Adds --triton-trace (and --ml-api-trace for all backends) for profiling and --list-triton-operators / --triton-operator for analysis, driven by a shared backend registry.
Each marker is tagged with its framework so Triton and Torch kernels are analyzed independently.
Marker names are percent-encoded so names containing slashes don't break parsing, with identical encode/decode in the Python tier and the analyzer.
Adds Triton backend unit tests (launch-point wrapping, reentrancy, kernel-name resolution, percent-encode round trip), C++ gtests for encode/decode symmetry, framework-selection and per-backend analyze-filter tests, and a GPU+Triton-gated end-to-end profile-and-analyze test over a sample Triton workload.
Adds two cached profiling workloads: tests/workloads/triton_trace/MI300A and tests/workloads/ml_api_trace/MI300A, so the per-backend analyze tests run CPU-only in CI.

JIRA ID

AIPROFCOMP-635

Test Plan

Triton backend unit tests (wrapping, reentrancy dedup, kernel-name, percent-encode round trip)
ctest -R test_inject_roctx_package

Framework selection (flag -> backend, env var)
ctest -R test_profiler_base

Analyze: per-backend operator filtering
ctest -R test_analyze_workloads

Utils: operator pattern parsing
ctest -R test_utils

C++ gtests: percent-encode + round-trip decode
ctest -R test-roctx-recordfn

End-to-end Triton profile + analyze (requires GPU + Triton)
ctest -R test_profile_triton_trace

Test Result

Tests Pass

Submission Checklist

Look over the contributing guidelines at https://github.com/ROCm/ROCm/blob/develop/CONTRIBUTING.md#pull-requests.

Copilot

Pull request overview

This PR extends rocprofiler-compute’s ROCTX marker injection and analysis pipeline to support a Triton backend alongside the existing PyTorch backend, adding new CLI flags, backend-aware operator filtering/listing, and shared Python-tier ROCTX initialization.

Changes:

Add Triton tracing/profile CLI support (--triton-trace) and analysis CLI support (--list-triton-operators, --triton-operator) with updated docs.
Implement and test a hardened Triton ROCTX injection backend that wraps Triton kernel launch entry points and attributes markers to a Backend column.
Generalize analyze-side operator selection/listing to be backend-aware (torch vs triton), including per-backend matched trace storage.

Reviewed changes

Copilot reviewed 13 out of 13 changed files in this pull request and generated 2 comments.

Show a summary per file

File	Description
projects/rocprofiler-compute/tests/test_utils.py	Adds tests for backend-aware operator pattern parsing and backend filtering in analysis CLI.
projects/rocprofiler-compute/tests/test_profiler_base.py	Adds tests validating CLI framework selection and subprocess env var construction.
projects/rocprofiler-compute/tests/test_inject_roctx_module.py	Adds Triton backend unit tests (wrapping behavior, reentrancy guard, python-tier handling, kernel name extraction).
projects/rocprofiler-compute/src/utils/tty.py	Generalizes operator listing output to support a configurable framework label (PyTorch/Triton).
projects/rocprofiler-compute/src/utils/schema.py	Extends `Workload` to store matched API-trace rows per backend.
projects/rocprofiler-compute/src/utils/inject_roctx/_core.py	Introduces shared Python-tier ROCTX initialization (`ensure_python_tier`) and candidate path tracking.
projects/rocprofiler-compute/src/utils/inject_roctx/_backends/_triton.py	Adds/extends Triton backend wrapping logic for kernel launches and framework-root registration.
projects/rocprofiler-compute/src/utils/inject_roctx/_backends/_torch.py	Switches torch backend to use shared Python-tier initialization and shared candidate-path reporting.
projects/rocprofiler-compute/src/rocprof_compute_profile/profiler_base.py	Adds Triton framework selection mapping for ROCTX injection env var.
projects/rocprofiler-compute/src/rocprof_compute_analyze/analysis_cli.py	Refactors operator list/filter flow to be backend-aware and adds backend filtering on consolidated API traces.
projects/rocprofiler-compute/src/argparser.py	Adds CLI flags for Triton tracing and Triton operator listing/filtering.
projects/rocprofiler-compute/docs/how-to/profile/mode.rst	Documents Triton trace usage, requirements, and relationship to ROCTX frameworks env var.
projects/rocprofiler-compute/docs/how-to/analyze/cli.rst	Documents Triton operator analysis and its CLI usage.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Co-authored-by: Pratik Basyal <pratik.basyal@amd.com>

Co-authored-by: cfallows-amd <Carrie.Fallows@amd.com>

…d-triton-backend

xuchen-amd

thanks for addressing my comments, I would appreciate another reviewer feedback (a third one in addition to Carrie and myself).

vedithal-amd

will do a quick review by EOD here

vedithal-amd

A few maintenance-cost notes on the docs plus a coverage-gap flag on the Triton path. See inline.

vedithal-amd

One follow-up note on package naming (see inline).

- C++ build_marker_string: exact reserve() for percent-encoding, extract encode_marker_segment + shared escape constants reused by the round-trip test - analysis_base: collapse per-backend trace-validation into one loop - rename KNOWN_BACKENDS -> KNOWN_ML_API_BACKENDS - rename _BACKEND_CLI -> _ML_API_ANALYSIS_CLI_OPTIONS - utils_analysis: inline decode_marker_name in build_call_trees - test_utils: drop redundant function-local pandas imports Co-Authored-By: Claude <noreply@anthropic.com>

vedithal-amd

LGTM

Pushed one commit (60e1e65) with review nits, all mechanical, no behavior change:

C++ build_marker_string: exact reserve() accounting for percent-encoding; extracted encode_marker_segment + shared escape constants, reused by the round-trip test so the escape table has one definition.
analysis_base: collapsed the duplicated per-backend trace-validation into a single loop over the backend list.
Renamed KNOWN_BACKENDS -> KNOWN_ML_API_BACKENDS and _BACKEND_CLI -> _ML_API_ANALYSIS_CLI_OPTIONS.
utils_analysis: inlined decode_marker_name in build_call_trees.
test_utils: dropped redundant function-local pandas imports.

Follow-ups left as separate notes (not blocking): rename _backends -> backends, and ML-API coverage test.

Resolved all the issues raised by Pratik. But dismissing since he is OOO this week and can't approve before the end of this sprint. For the sake of unblocking

…d-triton-backend

ggottipa-amd requested review from a team and prbasyal-amd as code owners June 8, 2026 09:28

Copilot AI review requested due to automatic review settings June 8, 2026 09:28

ggottipa-amd requested a review from a team as a code owner June 8, 2026 09:28

ggottipa-amd marked this pull request as draft June 8, 2026 09:28

Copilot started reviewing on behalf of ggottipa-amd June 8, 2026 09:28 View session

github-actions Bot added documentation Improvements or additions to documentation project: rocprofiler-compute labels Jun 8, 2026

Copilot AI reviewed Jun 8, 2026

View reviewed changes

Comment thread projects/rocprofiler-compute/src/utils/inject_roctx/_backends/_triton.py Outdated

Comment thread projects/rocprofiler-compute/src/rocprof_compute_analyze/analysis_cli.py Outdated

systems-assistant Bot added the organization: ROCm label Jun 8, 2026

ggottipa-amd force-pushed the users/ggottipa-amd/inject-roctx-multi-framework branch 2 times, most recently from baf2456 to de095d3 Compare June 8, 2026 14:46

ggottipa-amd force-pushed the users/ggottipa-amd/add-triton-backend branch from f2d20b8 to 50aabb3 Compare June 9, 2026 09:01

ggottipa-amd marked this pull request as ready for review June 11, 2026 16:17

ggottipa-amd changed the title ~~Adding Triton backend to marker injection~~ [rocprof-compute] Adding Triton backend to marker injection Jun 12, 2026

ggottipa-amd force-pushed the users/ggottipa-amd/inject-roctx-multi-framework branch from c4ac4c9 to 46559c0 Compare June 15, 2026 06:41

ggottipa-amd requested a review from a team as a code owner June 15, 2026 06:41

ggottipa-amd marked this pull request as draft June 17, 2026 14:24

ggottipa-amd force-pushed the users/ggottipa-amd/inject-roctx-multi-framework branch from 61a6658 to 81ee094 Compare June 18, 2026 11:28

ggottipa-amd force-pushed the users/ggottipa-amd/add-triton-backend branch from 657626d to 7007129 Compare June 18, 2026 12:43

ggottipa-amd marked this pull request as ready for review June 18, 2026 14:28

cfallows-amd reviewed Jun 19, 2026

View reviewed changes

Comment thread projects/rocprofiler-compute/src/utils/inject_roctx/_backends/triton.py Outdated

Comment thread projects/rocprofiler-compute/src/utils/inject_roctx/_backends/triton.py Outdated

Comment thread projects/rocprofiler-compute/tests/test_inject_roctx_package.py Outdated

ggottipa-amd force-pushed the users/ggottipa-amd/add-triton-backend branch from a88ff64 to 6a8df5c Compare June 19, 2026 09:06

ggottipa-amd force-pushed the users/ggottipa-amd/inject-roctx-multi-framework branch 2 times, most recently from bff659e to b0b3164 Compare June 22, 2026 12:29

ggottipa-amd force-pushed the users/ggottipa-amd/add-triton-backend branch from b72859d to ab4f20e Compare June 22, 2026 14:58

Base automatically changed from users/ggottipa-amd/inject-roctx-multi-framework to rocprofiler-compute-develop June 22, 2026 18:03

ggottipa-amd force-pushed the users/ggottipa-amd/add-triton-backend branch 3 times, most recently from 47add6b to 41d52a1 Compare June 24, 2026 09:27

ggottipa-amd and others added 10 commits June 29, 2026 08:01

Update projects/rocprofiler-compute/docs/how-to/analyze/cli.rst

2b9c318

Co-authored-by: Pratik Basyal <pratik.basyal@amd.com>

test marker changed to triton-trace

b971d98

Moving flags to experimental section

6d60ec3

added idempotency test

7a3ba52

Update projects/rocprofiler-compute/tests/test_profile_general.py

3a46ca5

Co-authored-by: cfallows-amd <Carrie.Fallows@amd.com>

Update projects/rocprofiler-compute/tests/test_profile_general.py

7656cd3

Co-authored-by: cfallows-amd <Carrie.Fallows@amd.com>

resolving comments

7b8c9cb

removing stale flag check

dae1b20

adding sample triton operators listing

90cac98

adding cached workloads for testing new flags

491b779

ggottipa-amd force-pushed the users/ggottipa-amd/add-triton-backend branch from 066804e to 491b779 Compare June 29, 2026 08:02

ggottipa-amd added 2 commits June 29, 2026 08:10

registering test_profile_triton_trace

894decb

Merge branch 'rocprofiler-compute-develop' into users/ggottipa-amd/ad…

eadf69d

…d-triton-backend

cfallows-amd approved these changes Jun 29, 2026

View reviewed changes

xuchen-amd approved these changes Jun 29, 2026

View reviewed changes

feizheng10 reviewed Jun 29, 2026

View reviewed changes

Comment thread projects/rocprofiler-compute/docs/how-to/analyze/cli.rst

feizheng10 reviewed Jun 29, 2026

View reviewed changes

Comment thread projects/rocprofiler-compute/docs/how-to/analyze/cli.rst

feizheng10 reviewed Jun 29, 2026

View reviewed changes

Comment thread projects/rocprofiler-compute/docs/how-to/profile/mode.rst Outdated

vedithal-amd requested changes Jun 29, 2026

View reviewed changes

vedithal-amd reviewed Jun 29, 2026

View reviewed changes

Comment thread projects/rocprofiler-compute/docs/how-to/analyze/cli.rst

Comment thread projects/rocprofiler-compute/docs/how-to/profile/mode.rst Outdated

Comment thread projects/rocprofiler-compute/docs/how-to/profile/mode.rst

Comment thread projects/rocprofiler-compute/CMakeLists.txt

vedithal-amd reviewed Jun 29, 2026

View reviewed changes

Comment thread projects/rocprofiler-compute/src/utils/inject_roctx/_backends/triton.py

vedithal-amd approved these changes Jun 30, 2026

View reviewed changes

abchoudh-amd approved these changes Jun 30, 2026

View reviewed changes

Addressing comments

ccd5d6d

ggottipa-amd force-pushed the users/ggottipa-amd/add-triton-backend branch from 9ee8251 to ccd5d6d Compare June 30, 2026 05:50

Merge branch 'rocprofiler-compute-develop' into users/ggottipa-amd/ad…

8db192c

…d-triton-backend

ggottipa-amd merged commit 7026950 into rocprofiler-compute-develop Jun 30, 2026
27 checks passed

ggottipa-amd deleted the users/ggottipa-amd/add-triton-backend branch June 30, 2026 09:00

Uh oh!

Conversation

ggottipa-amd commented Jun 8, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Motivation

Technical Details

JIRA ID

Test Plan

Test Result

Submission Checklist

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

xuchen-amd left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

vedithal-amd left a comment

Choose a reason for hiding this comment

Uh oh!

vedithal-amd left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

vedithal-amd left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

vedithal-amd left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

ggottipa-amd commented Jun 8, 2026 •

edited

Loading